Using flash for this is silly, and has weird effects as observed in the fact that I had to fix a test which had accidentally relied on fetching user details from the API causing a session to spring into existence because it wrote to flash. You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5658 -- Commit Summary -- * Stop using session flash to communicate with callbacks -- File Changes -- M app/controllers/accounts/terms_controller.rb (3) M app/controllers/api/users_controller.rb (12) M app/controllers/api_controller.rb (8) M app/controllers/application_controller.rb (4) M app/controllers/concerns/session_methods.rb (9) M app/controllers/sessions_controller.rb (4) M test/integration/user_blocks_test.rb (2) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/5658.patch https://github.com/openstreetmap/openstreetmap-website/pull/5658.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5658 You are receiving this because you are subscribed to this thread. Message ID: <openstreetmap/openstreetmap-website/pull/5...@github.com>
_______________________________________________ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
