@tomhughes commented on this pull request.


> @@ -0,0 +1,23 @@
+module Api
+  module UserBlocks
+    class ActiveListsController < ApiController
+      before_action :disable_blocks_check

Why use flash to smuggle the skip blocks flag to `setup_user_auth`? Could we 
not just pass an argument to the `authorize` callback and have that pass it on 
to `setup_user_auth`?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5452#pullrequestreview-2610172848
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/5452/review/2610172...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to