@tomhughes commented on this pull request.
> if (response.code !== "Ok") {
- return callback(true);
+ throw new TypeError("Response " + response.code);
Sure, but this doesn't really fit the description of `TypeError` at
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypeError
does it? So maybe just use `Error` instead?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5642#discussion_r1951491482
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5642/review/2609850...@github.com>_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
