@nertc commented on this pull request.
> @@ -231,10 +231,15 @@
</div>
<% end %>
-<div class="richtext text-break clearfix"><%= @user.description.to_html
%></div>
-
-<% if current_user and @user.id == current_user.id %>
- <div class="my-3">
- <%= link_to t(".edit_profile"), edit_profile_path, :class => "btn
btn-outline-primary" %>
+<div class="row">
+ <div class="col-sm-3">
+ <%= render "social_links/show",
+ :social_links => @user.social_links %>
+ <% if current_user and @user.id == current_user.id %>
+ <div class="my-3">
+ <%= link_to t(".edit_profile"), edit_profile_path, :class => "btn
btn-outline-primary" %>
+ </div>
+ <% end %>
I also thought about a separate page or in-place editing for social links, but
for consistency, preferred to keep it in the way that everything is done on the
profile page. I agree with you about changing general behavior of editing
profile page, but, I think, it will be better if we do it as a separate issue
and PR and it will change not some part of `profile/edit` but whole behavior to
in-place edit. For now, to avoid any confusion from users about the function of
the button, I'll move it to where it was before (under the description block).
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5439#discussion_r1949664318
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5439/review/2606794...@github.com>_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
