If I'm making purely ui tests here I can't possibly know id of new
notes, therefore I shouldn't check them.
But the actual reason is that it looks like `assert_content "Unresolved
note ##{Note.last.id}"` line is sometimes reached before db writes are
complete. `Note.last.id` is not going to have an expected value in these cases.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5593
-- Commit Summary --
* Don't check ids of new notes in create note system tests
-- File Changes --
M test/system/create_note_test.rb (4)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/5593.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5593.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5593
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
