@AntonKhorev commented on this pull request.


> +      data: {
+        source: heatmapData,
+        type: "json",
+        x: "date",
+        y: "total_changes"
+      },
+      scale: {
+        color: {
+          type: "threshold",
+          range: currentTheme === "dark" ? rangeColors : 
Array.from(rangeColors).reverse(),
+          domain: [10, 20, 30, 40]
+        }
+      }
+    }, [
+      [Tooltip, {
+        text: (date, value) => getTooltipText(date, value, locale)

`getTooltipText` doesn't have the `locale` parameter. And you probably don't 
need to pass `locale` around to other places, given that you can read it from 
`I18n.locale`.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5402#pullrequestreview-2586720269
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/5402/review/2586720...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to