@etiennejourdier commented on this pull request.
> @@ -152,6 +152,16 @@ OSM.NewNote = function (map) {
.on("input", updateControls)
.focus();
+ var anonymousNotesCount =
Number(localStorage.getItem("anonymousNotesCount"));
+
+ if (typeof OSM.user === "undefined" && anonymousNotesCount >= 20) {
+ var counterWarning = content.find("#new-note-counter-warning");
+ if (typeof counterWarning.html() !== "undefined") {
+ counterWarning.html(counterWarning.html().replace("(N)",
anonymousNotesCount));
OK I understood how pluralization works with i18n, but it is server-side ... If
the value of the counter is in the browser (whether in a cookie or in
localStorage), it has to be inserted by jquery, so after the translation, and
it's too late to manage the different plurals, right ? Is there another option
to manage plurals with jquery ? Or is it why you propose the counter to be
server-side ?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5468#discussion_r1903357181
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5468/review/2530981...@github.com>_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
