This changes the user settings page to use turbo to fix the problem identified in https://github.com/openstreetmap/openstreetmap-website/pull/5449#issuecomment-2565252266 where the URL changes when submitting a settings page with errors.
It also fixes an issue where errors weren't moved from the `email` to the `new_email` attribute properly, and simplifies checking if errors are present. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5453 -- Commit Summary -- * Use turbo for the settings page to stop the URL changing * Replace count.zero? with empty? * Move errors from email to new_email properly -- File Changes -- M app/controllers/accounts_controller.rb (4) M app/controllers/concerns/user_methods.rb (5) M app/views/accounts/edit.html.erb (2) M test/controllers/accounts_controller_test.rb (8) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/5453.patch https://github.com/openstreetmap/openstreetmap-website/pull/5453.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5453 You are receiving this because you are subscribed to this thread. Message ID: <openstreetmap/openstreetmap-website/pull/5...@github.com>
_______________________________________________ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
