@tomhughes commented on this pull request.
This mostly looks fine. I think the only thing I'm not sure about is moving
`user#details` into a separate controller - it's basically an alias for
`user#show` so does it make any sense to separate it?
That said @gravitystorm has a better grasp than me of what is the canonical
rails to do these things so I'd be interest to here what he thinks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5433#pullrequestreview-2519601627
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5433/review/2519601...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
