This converts the confusingly named `SocialShareButtonHelper` which is really a library, but tested by a helper test, into a real helper and moves the actual `render_social_share_buttons` helper there from the application helper.
The other methods are then private as they're only used by `render_social_share_buttons` so are no longer tested separately as they're not visible to the test but will be tested implicitly by the calls to `render_social_share_buttons` in the other tests so coverage should be the same. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5413 -- Commit Summary -- * Convert social share helper library into a real helper -- File Changes -- M app/helpers/application_helper.rb (29) R app/helpers/social_share_button_helper.rb (38) M test/helpers/social_share_button_helper_test.rb (12) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/5413.patch https://github.com/openstreetmap/openstreetmap-website/pull/5413.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5413 You are receiving this because you are subscribed to this thread. Message ID: <openstreetmap/openstreetmap-website/pull/5...@github.com>
_______________________________________________ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
