@hlfan commented on this pull request.


> @@ -516,6 +511,23 @@ body.small-nav {
   }
 }
 
+@mixin dark-map-color-scheme {
+  .leaflet-tile-container .leaflet-tile,
+  .mapkey-table-entry td:first-child > * {
+    filter: brightness(.8);

Doesn't the mentioned step 5 include the need for the filters to be set 
individually to give the cartographers a choice?
I don't see that as a necessity for this PR, but already setting the filter 
through a custom property defined on the layer could ease the transition to 
that being implemented and also act as default and fallback:
```css
here {
    filter: var(--dark-map-filter);
}
somewhere else {
    .leaflet-layer {
        --dark-map-filter: brightness(.8);
    }
}
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5362#pullrequestreview-2475209721
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/5362/review/2475209...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to