@tomhughes commented on this pull request.
This mostly looks good - my only question would be about error handling for
subscribe/unsubscribe as the error text reporting has been moved to only happen
for the comment button.
The equivalent code for changesets reports the error in all cases by the looks
of it - you can certainly argue that putting the text under the comment box in
that case is not ideal but it's probably better than not showing it and errors
should be very rare.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5346#pullrequestreview-2452356924
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5346/review/2452356...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
