> because "making it a little less dim" is assumed to clearly fix everyone's
> problem with the changes.
That's not why it was merged, and I think if you read #5328 you'll see that I'm
not "assuming that it's going to fix everyone's problems". That's a pretty
unfair characterisation.
> There are little to no comments being made in this PR by the maintainers as
> to what needs to change for it to get merged
It's been less than 22 hours since you opened it. I haven't reviewed this PR
specifically, but you can see from the discussion in #5328 that there's lots to
consider about the invert+rotate approach. It's not a PR which is a
straightforward merge, and even if it was, 22 hours is asking a lot in terms of
turnaround from a handful of volunteers.
> whether there are plans to revert the failed dark mode
I think "failed" is also unfair. There's more to dark mode than just effect on
the maps, it took months of work and dozens of changes across that rest of the
site too. That's why we are discussing things in separate issues. Even today
we've been making improvements to other aspects of the dark mode UI changes,
which are unrelated to the maps.
> without any discussion or consultation whatsoever
#4769 was opened in May, but unfortunately there was no substantial discussion.
> not bother trying to upstream any improvements, or contribute to the website
> going forward.
That's a shame, we do welcome everyone to get involved. I've even given
conference talks about what we do to make things easier (e.g.
[1](https://www.youtube.com/watch?v=99_ecrNOMPs&t=27s)
[2](https://www.gravitystorm.co.uk/blog/2024/10/19/maintaining-openstreetmap-lrug/)).
You can also see the endless list of PRs we make with the Developer Experience
(dx) tag. I know it's a long way from perfect, but we're a small team with a
lot of work to do.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5325#issuecomment-2479794468
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5325/c2479794...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
