Fixes #5305. Currently query markers are animated using javascript which requires managing timed events. We don't do it correctly, we don't cancel them when markers are removed. That's why #5305 happens.
This PR replaces the javascript animation with the css which doesn't require any event handlers. I could have added animation end events to remove the marker layer but once faded out it doesn't affect anything and it's cleaned up in `page.unload`. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5307 -- Commit Summary -- * Replace query marker fade animation with css -- File Changes -- M app/assets/javascripts/index/query.js (17) M app/assets/stylesheets/common.scss (8) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/5307.patch https://github.com/openstreetmap/openstreetmap-website/pull/5307.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5307 You are receiving this because you are subscribed to this thread. Message ID: <openstreetmap/openstreetmap-website/pull/5...@github.com>
_______________________________________________ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
