Hi Heikki, On 2016-06-21 12:58, Heikki Vatiainen wrote: > On 13.06.2016 10:27, Hartmaier Alexander wrote: > >>> I also noticed that we can get the peer IP and port from accept directly >>> instead of calling getpeername(). What is done now is to check accept >>> return value for success and call getpeername() immediately after that. >> I haven't seen that change in the patches, is it already in there so I >> can try it out? > It's in the patches now. The IP address and port of the connecting > client are now immediately logged after access instead in addition to > calling getpeername() just a little later. The logging currently happens > on trace 4 (debug) level. > > We also thought about further improvements for unexpectedly closed > connections so that they can be logged and handled more easily. However, > this is the first step before doing further changes. We still get the 'Could not get peer name on TacacsplusConnection socket: Transport endpoint is not connected' log message without additional infos for which endpoint. Please don't add an additional debugging message but improve the existing one! > > Thanks, > Heikki > Thanks, Alex
*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"* T-Systems Austria GesmbH Rennweg 97-99, 1030 Wien Handelsgericht Wien, FN 79340b *"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"* Notice: This e-mail contains information that is confidential and may be privileged. If you are not the intended recipient, please notify the sender and then delete this e-mail immediately. *"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"* _______________________________________________ radiator mailing list radiator@open.com.au http://www.open.com.au/mailman/listinfo/radiator