Urghh.... really? The existing behavior is clearly broken, and this library is--to the best of my knowledge--used by a relatively small number of people. Francisco, as the original author of this code, do you have an opinion?
On Wed, Mar 4, 2015 at 12:13 PM, Sam Tobin-Hochstadt <sa...@cs.indiana.edu> wrote: > > > On Wed, Mar 4, 2015 at 3:06 PM John Clements <johnbcleme...@gmail.com> > wrote: > >> I see that the documentation suggests that (entity-charset) is supposed >> to return a symbol. However, it nearly always returns a string. In >> particular, it appears to me that it returns a symbol only when it returns >> its default, 'us-ascii. >> >> I feel compelled to repair this, but there are two ways to fix it: >> 1) make it match the docs and always return a symbol, or >> 2) change the docs and the default to return a string. >> >> It looks to me like #2 will break (less) code, though it's certainly >> possible that people depend on the default value's being a string. >> > > It seems like option #3, document the current behavior, will break the > least code, and that we should do that. > > Sam >
____________________ Racket Users list: http://lists.racket-lang.org/users
