On 26/07/2021 3:34 p.m., Kent Johnson wrote:
Thanks, Duncan,
I did consult with Dirk about the warnings. The #pragma in Boost headers
which disables those warnings is not allowed in a CRAN submission, so he
removed the #pragma, enabling the warnings >
I see that Boost does call std::abort in its error handling. I don't
think I can do anything about that...
If you look at the BH page on CRAN, there are a ton of "reverse linking
to" packages, i.e. packages that are doing something like what you do.
It would be worth looking at a few of those that don't generate those
warnings (e.g. abcADM, ACEt, etc.) to see if they're using the same
parts of Boost as you're using, and have found a way to avoid the warnings.
Duncan Murdoch
Kent
------------------------------------------------------------------------
*From:* Duncan Murdoch <murdoch.dun...@gmail.com>
*Sent:* Monday, July 26, 2021 3:12 PM
*To:* Kent Johnson <kjohn...@akoyabio.com>;
r-package-devel@r-project.org <r-package-devel@r-project.org>
*Subject:* Re: [R-pkg-devel] CRAN submission with warnings
Regarding the issues:
Since one of them comes from the BH package rather than yours, you might
want to talk to Dirk for advice about it.
The second issue you mention in your comment looks more serious:
"Found 'abort', possibly from 'abort' (C), 'runtime' (Fortran) Found
'exit', possibly from 'exit' (C), 'stop' (Fortran) Found 'printf',
possibly from 'printf' (C)".
Your response that you don't call 'abort', 'exit' or 'printf' isn't
sufficient here: those functions appear to have been linked in to your
DLL, so somebody is calling them. I'd try to track down those calls and
see if there's a way to compile without them.
Duncan Murdoch
>
> win-builder results are here:
https://win-builder.r-project.org/incoming_pretest/rtree_0.2.0_20210721_153225/Windows/00check.log
<https://win-builder.r-project.org/incoming_pretest/rtree_0.2.0_20210721_153225/Windows/00check.log>
> cran-comments.md here:
https://github.com/akoyabio/rtree/blob/master/cran-comments.md
<https://github.com/akoyabio/rtree/blob/master/cran-comments.md>
>
> Thank you for any guidance,
> Kent Johnson
> Akoya Biosciences
>
> [[alternative HTML version deleted]]
>
> ______________________________________________
> R-package-devel@r-project.org mailing list
> https://stat.ethz.ch/mailman/listinfo/r-package-devel
<https://stat.ethz.ch/mailman/listinfo/r-package-devel>
>
______________________________________________
R-package-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-package-devel
