Oh, I missed that. Thank you Max and Duncan! *Matt Dancho | Founder, CEO | Business Science* p: 570-419-4337 <(570)%20419-4337> | www.business-science.io
Want to learn Data Science for Business? Get started today with Business Science <https://university.business-science.io/>. <http://www.business-science.io/> <https://twitter.com/bizScienc> On Tue, Sep 1, 2020 at 12:23 PM Max Turgeon <max.turg...@umanitoba.ca> wrote: > Hi Matt, > > > If you addressed the issues with the current CRAN version, then I would go > with Duncan's suggestion below and treat this as a false positive. > > > Best, > > > Max Turgeon > Assistant Professor > Department of Statistics > Department of Computer Science > University of Manitoba > maxturgeon.ca > > > ------------------------------ > *From:* Matt Dancho <mdan...@business-science.io> > *Sent:* September 1, 2020 11:18:52 AM > *To:* Duncan Murdoch > *Cc:* Max Turgeon; r-package-devel@r-project.org > *Subject:* Re: [R-pkg-devel] Modeltime 0.1.0 Submission Failing - Not > Sure What To Do > > *Caution:* This message was sent from outside the University of Manitoba. > Hi Max, > > I appreciate the quick response - The webshot should no longer be an > issue. My latest submission has only one vignette and I switched all of the > plots from interactive (which uses webshot to convert to PNG) to ggplot2 so > webshot should not be necessary. > > I think the CRAN Modeltime 0.2.0 results should be corrected. The only one > I see that may still be an issue is the prophet library, which modeltime > uses. > > What do you think? > > *Matt Dancho | Founder, CEO | Business Science* > p: 570-419-4337 <(570)%20419-4337> | www.business-science.io > > Want to learn Data Science for Business? Get started today with Business > Science <https://university.business-science.io/>. > > <http://www.business-science.io/> <https://twitter.com/bizScienc> > > > On Tue, Sep 1, 2020 at 12:00 PM Duncan Murdoch <murdoch.dun...@gmail.com> > wrote: > >> On 01/09/2020 11:52 a.m., Max Turgeon wrote: >> > Hi Matt, >> > >> > >> > If you scroll down just below the Windows and Debian OKs, you'll see >> these lines: >> > >> > >> > Last released version's CRAN status: ERROR: 1, WARN: 3, NOTE: 1, OK: 7 >> > See: < >> https://CRAN.R-project.org/web/checks/check_results_modeltime.html >> > <https://cran.r-project.org/web/checks/check_results_modeltime.html>> >> > >> > >> > It seems one of your vignettes is causing issues when trying to use >> phantomJS. >> >> That message is about the version that's on CRAN, not the new >> submission. I think Matt should just follow this directions: "If you >> are fairly certain the rejection is a false positive, please reply-all >> to this message and explain." Having OK results rejected sure seems >> like a false positive! >> >> Duncan Murdoch >> >> > >> > >> > Best, >> > >> > >> > Max Turgeon >> > Assistant Professor >> > Department of Statistics >> > Department of Computer Science >> > University of Manitoba >> > maxturgeon.ca<http://maxturgeon.ca> >> > >> > >> > ________________________________ >> > From: R-package-devel <r-package-devel-boun...@r-project.org> on >> behalf of Matt Dancho <mdan...@business-science.io> >> > Sent: September 1, 2020 10:26:06 AM >> > To: r-package-devel@r-project.org >> > Subject: [R-pkg-devel] Modeltime 0.1.0 Submission Failing - Not Sure >> What To Do >> > >> > ******************************************************** >> > Caution: This message was sent from outside the University of Manitoba. >> > ******************************************************** >> > >> > Hi, >> > >> > I'm having a difficult time with the pre-tests for Modeltime 0.1.0, a >> new >> > version that I'm trying to get onto CRAN. The pre-tests indicate >> Windows & >> > Debian are OK. Any help would be much appreciated. >> > >> > Thanks, Matt >> > >> > >> > *CRAN Pretest Results* >> > >> > Dear maintainer, >> > >> > package modeltime_0.1.0.tar.gz does not pass the incoming checks >> > automatically, please see the following pre-tests: >> > Windows: < >> > >> https://win-builder.r-project.org/incoming_pretest/modeltime_0.1.0_20200901_161424/Windows/00check.log >> >> >> > Status: OK >> > Debian: < >> > >> https://win-builder.r-project.org/incoming_pretest/modeltime_0.1.0_20200901_161424/Debian/00check.log >> >> >> > Status: OK >> > >> > Last released version's CRAN status: ERROR: 1, WARN: 3, NOTE: 1, OK: 7 >> > See: < >> https://CRAN.R-project.org/web/checks/check_results_modeltime.html >> > <https://cran.r-project.org/web/checks/check_results_modeltime.html>> >> > >> > CRAN Web: <https://cran.r-project.org/package=modeltime> >> > >> > Please fix all problems and resubmit a fixed version via the webform. >> > If you are not sure how to fix the problems shown, please ask for help >> on >> > the R-package-devel mailing list: >> > <https://stat.ethz.ch/mailman/listinfo/r-package-devel> >> > If you are fairly certain the rejection is a false positive, please >> > reply-all to this message and explain. >> > >> > More details are given in the directory: >> > < >> > >> https://win-builder.r-project.org/incoming_pretest/modeltime_0.1.0_20200901_161424/ >> >> >> > The files will be removed after roughly 7 days. >> > >> > No strong reverse dependencies to be checked. >> > >> > Best regards, >> > CRAN teams' auto-check service >> > Flavor: r-devel-windows-ix86+x86_64 >> > Check: CRAN incoming feasibility, Result: NA >> > Maintainer: 'Matt Dancho <mdan...@business-science.io>' >> > >> > Flavor: r-devel-windows-ix86+x86_64 >> > Check: Overall checktime, Result: NOTE >> > Overall checktime 16 min > 10 min >> > >> > Flavor: r-devel-linux-x86_64-debian-gcc >> > Check: CRAN incoming feasibility, Result: Note_to_CRAN_maintainers >> > Maintainer: 'Matt Dancho <mdan...@business-science.io>' >> > >> > >> > >> > *Matt Dancho | Founder, CEO | Business Science* >> > p: 570-419-4337 <(570)%20419-4337> | www.business-science.io< >> http://www.business-science.io> >> > >> > Want to learn Data Science for Business? Get started today with Business >> > Science <https://university.business-science.io/>. >> > >> > <http://www.business-science.io/> <https://twitter.com/bizScienc> >> > >> > [[alternative HTML version deleted]] >> > >> > ______________________________________________ >> > R-package-devel@r-project.org mailing list >> > https://stat.ethz.ch/mailman/listinfo/r-package-devel >> > >> > >> > [[alternative HTML version deleted]] >> > >> > ______________________________________________ >> > R-package-devel@r-project.org mailing list >> > https://stat.ethz.ch/mailman/listinfo/r-package-devel >> > >> >> [[alternative HTML version deleted]] ______________________________________________ R-package-devel@r-project.org mailing list https://stat.ethz.ch/mailman/listinfo/r-package-devel
