With that change to the .desktop file, both the existing rgl and the rgl with a group_leader set behave the same: all x11() and rgl windows are collected together into the same R icon.

If I don't make that change, then setting the group_leader causes all rgl windows from one process to group together (with a bad icon).

I think I'll leave the group_leader in place. I'll think about setting an icon, but I don't see it as urgent.

Duncan Murdoch

On 23/03/2021 1:36 p.m., Dirk Eddelbuettel wrote:

It all works now, thanks mostly to some very detailed reading of the specs by
Ivan.  In short, I made the following changes:

   - add the missing WM hint to the .desktop file we install
   - add the svg logo as 'scalable'
   - create a new (square) 48x48 default png logo from the new one
   - deactivate yesterday's patch

and it is all good now.  Duncan's rgl windows aggregate under the item, as do
the standard R x11 devices.  I will try to attach a small screenshot, we'll
see how mailman likes it.  Martin should still be able to get the old (and to
me, buggy) behaviour back by removing the one key line from the .desktop
file, if his Fedora environment ever updates as I plan.

For anyone on Ubuntu 20.10, updated binaries are in my PPA, see
https://launchpad.net/~edd/+archive/ubuntu/misc/+packages?field.name_filter=r-base&field.status_filter=published&field.series_filter=groovy

Changelog entries below, these have not been committed to Debian's git yet
but I think I will activate this for R 4.0.5 next week (and test it til
then). Screenshot attached below too.

------ changelog for these three test builds follows  -----------------------

r-base (4.0.4-1.2010.3) groovy; urgency=medium

   * debian/r-base-core.dirs: Also create the directory
     usr/share/icons/hicolor/scalable/apps for the svg logo

  -- Dirk Eddelbuettel <e...@debian.org>  Tue, 23 Mar 2021 11:05:17 -0500

r-base (4.0.4-1.2010.2) groovy; urgency=medium

   * icon-class-patch/R.desktop: Add 'StartupWMClass=R_x11'
   * icon-class-patch/rlogo_icon.OLD.png.mpack: Renamed old icon
   * icon-class-patch/rlogo_icon.png.mpack: New 48x48 png from svg
   * icon-class-patch/Rlogo.svg: Copy of official logo
   * debian/rules: Also install Rlogo.svg in 'scalable' icons dir

   * debian/patches/series: Deactivate unneeded grouping patch

  -- Dirk Eddelbuettel <e...@debian.org>  Tue, 23 Mar 2021 10:27:43 -0500

r-base (4.0.4-1.2010.1) groovy; urgency=medium

   * PPA build on Ubuntu 20.10 "groovy"
   * src/modules/X11/devX11.c: Apply patch by Ivan Krylov (posted to r-devel
     on 2021-03-22) enabling grouping of x11 plot device windows

  -- Dirk Eddelbuettel <e...@debian.org>  Mon, 22 Mar 2021 21:33:09 -0500

-----------------------------------------------------------------------------


Dirk





______________________________________________
R-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel

Reply via email to