I abandoned my patch, but it was a good chance to look at test_quantum.py. Dan's comment in my patch is correct. The comment in the code should be fixed in near future to avoid the confusion.
I agree we need to improve the coverage in test_quantumv2 from the feature perpective. In addition, I feel test_quantumv2 becomes too large to maintain. Thanks, Akihiro >>>>> Date: Thu, 28 Mar 2013 09:28:50 -0700 >>>>> From: Dan Wendlandt <d...@nicira.com> >>>>> Subject: Re: [Quantum-core] vm launch with port-id does not work > > Well, better that two people fix it than none :) > > I did have a comment on Akihiro's review that may also apply to Aaron's. Not > critical, but it > seems like a comment may be incorrect with the new change. > > dan > > On Thu, Mar 28, 2013 at 9:25 AM, Aaron Rosen <aro...@nicira.com> wrote: > > Hi Akihiro, > > I also noticed this a few days back and filed this > https://bugs.launchpad.net/nova/+bug/ > 1160560 , the patch https://review.openstack.org/#/c/25563/ merged last > night that fixes this > issue. > > Thanks, > > Aaron > > On Thu, Mar 28, 2013 at 2:57 AM, Akihiro MOTOKI <mot...@da.jp.nec.com> > wrote: > > Hi, > > I found the bug that vm launch with port-id does not work. > https://bugs.launchpad.net/nova/+bug/1161211 > The patch for nova is available at > https://review.openstack.org/#/c/25594/ > > It is worth fixing it before Grizzly release. > Could you ask nova-core to check it? > > Thanks, > Akihiro > > -- > Mailing list: https://launchpad.net/~quantum-core > Post to : quantum-core@lists.launchpad.net > Unsubscribe : https://launchpad.net/~quantum-core > More help : https://help.launchpad.net/ListHelp > > -- > Mailing list: https://launchpad.net/~quantum-core > Post to : quantum-core@lists.launchpad.net > Unsubscribe : https://launchpad.net/~quantum-core > More help : https://help.launchpad.net/ListHelp > > -- > ~~~~~~~~~~~~~~~~~~~~~~~~~~~ > Dan Wendlandt > Nicira, Inc: www.nicira.com > twitter: danwendlandt > ~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > -- Mailing list: https://launchpad.net/~quantum-core Post to : quantum-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~quantum-core More help : https://help.launchpad.net/ListHelp
