Yup, I agree as well and will approve. dan
On Sun, Feb 24, 2013 at 9:22 AM, Mark McClain <mark.mccl...@dreamhost.com>wrote: > I agree with Akihiro that migrations should move from one major release to > another. Those running interim milestone builds know the pitfalls of being > on the bleeding edge and should be equipped to handle it. Otherwise, we > could end up with lots of little migrations that obscure the final result > of a feature change. > > The lone exception to this rule would be a bug in the migration for stable > releases. If we have to fix the schema from 2013.1 to 2013.1.1, then a > migration for that point release would necessary. > > mark > > PS: I'm in favor of approving the latest version of Aaron's code to > remove external_id support. > > On Feb 24, 2013, at 12:00 PM, Akihiro MOTOKI <mot...@da.jp.nec.com> wrote: > > > Hi, > > > > In the review https://review.openstack.org/#/c/21924/, > > we are dropping external_id column from the securitygroups table. > > > > In my understanding, db migration is prepared to migrate from the > previous > > release to the new release (from Folsom to Grizzly at the moment). > > I am wondering which is better to modify the security_groups db > > migration script itself (which creates tables related to security groups) > > or to add a new migration script to drop external_id from securitygroups > table. > > > > IMO, the former looks better since changes during Grizzly development > cycle > > are not so important to users. > > > > Thanks, > > Akihiro > > > > -- > > Mailing list: https://launchpad.net/~quantum-core > > Post to : quantum-core@lists.launchpad.net > > Unsubscribe : https://launchpad.net/~quantum-core > > More help : https://help.launchpad.net/ListHelp > > > -- > Mailing list: https://launchpad.net/~quantum-core > Post to : quantum-core@lists.launchpad.net > Unsubscribe : https://launchpad.net/~quantum-core > More help : https://help.launchpad.net/ListHelp > -- ~~~~~~~~~~~~~~~~~~~~~~~~~~~ Dan Wendlandt Nicira, Inc: www.nicira.com twitter: danwendlandt ~~~~~~~~~~~~~~~~~~~~~~~~~~~
-- Mailing list: https://launchpad.net/~quantum-core Post to : quantum-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~quantum-core More help : https://help.launchpad.net/ListHelp
