Imported to qpsmtpd-dev. https://github.com/msimerson/qpsmtpd-dev/commit/b174bb0c4dd865312c264504935549e962004336
Matt On Jul 20, 2012, at 10:37 AM, Charlie Brady wrote: > > On Sat, 25 Feb 2012, Robin H. Johnson wrote: > >> I'm reopening this thread as I independently ran into it today, and I still >> don't see it in the Git repo. > > I still don't see it in the Git repo: > > https://github.com/smtpd/qpsmtpd/blob/master/lib/Qpsmtpd/SMTP.pm > > It's nearly a year now since Jared Johnson proposed a patch: > > http://grokbase.com/t/perl/qpsmtpd/118f562eah/patch-tweak-qps-header-handling-for-messages-with-no-body > > Gentoo has Robin's version of the patch in their port: > > http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/mail-mta/qpsmtpd/files/qpsmtpd-0.83-accept-empty-email.patch?view=markup > > Can we decide yay or nay, please? > >> I've attached a simpler patch than the previous version as well, it's >> had a few hours of testing only. >> >> A user tried to subscribe to a mailing list I run, and pinged me after 2 days >> because his sub request hadn't gone through. >> >> It was being handled incorrectly by qpsmtpd, such that $transaction->header >> was >> undef. >> >> The user's MTA was an up to date Ubuntu LTS Postfix, and his MUA is >> Thunderbird >> 10. >> >> == >> < DATA >>> 354 go ahead >> < Received: from mail.EXAMPLE.COM (localhost [127.0.0.1]) >> < by mail.EXAMPLE.COM (Postfix) with ESMTP id 8CE3D40B93 >> < for <vhs-general-subscr...@lists.hackspace.ca>; Thu, 23 Feb 2012 >> 05:15:33 +0000 (UTC) >> < DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=EXAMPLE.COM; >> < s=mail; t=1329974133; >> < bh=frcCV1k9oG9oKj3dpUqdJg1PxRT2RSN/XKdLCPjaYaY=; >> < h=Message-ID:Date:From:MIME-Version:To:Content-Type: >> < Content-Transfer-Encoding; >> < b=WJi1NKkoafASk0xmEx9trfC0+EnTFQoLGKKaw/+iWYRwNuTFG62rhyOqaMXie/Jy3 >> < zK7LZsg2FQFEhE0Gmx/+8UScndrUQUz+lBdEUw9uIPYqcrS06gCmnteu+oqCn+n5rB >> < s4SZfgDxYAPDtuvlrsxoNEnOqCf68jKHPnJamSoQ= >> < Received: from [10.10.30.124] (unknown [AA.BB.CC.DD]) >> < by mail.EXAMPLE.COM (Postfix) with ESMTPSA >> < for <vhs-general-subscr...@lists.hackspace.ca>; Thu, 23 Feb 2012 >> 05:15:29 +0000 (UTC) >> < Message-ID: <4f45cbdc.9070...@example.com> >> < Date: Wed, 22 Feb 2012 21:17:16 -0800 >> < From: USER <u...@example.com> >> < User-Agent: Mozilla/5.0 (X11; Linux i686; rv:10.0.1) Gecko/20120208 >> Thunderbird/10.0.1 >> < MIME-Version: 1.0 >> < To: vhs-general-subscr...@lists.hackspace.ca >> < Content-Type: text/plain; charset=ISO-8859-1; format=flowed >> < Content-Transfer-Encoding: 7bit >> < . >>> 451 Queuing declined or disabled; try again later >> === >> >> In my logs, fun stuff like this: >> FATAL PLUGIN ERROR [spamassassin]: Can't call method "as_string" on an >> undefined value at /usr/share/qpsmtpd/plugins/spamassassin line 154, <STDIN> >> line 9. >> FATAL PLUGIN ERROR [queue::qmail_2dqueue]: Can't call method "print" on an >> undefined value at /usr/share/qpsmtpd/plugins/queue/qmail-queue line 59, >> <STDIN> line 9. >> >>
