On Sat, 14 Mar 2009 17:24:18 -0700
Ask Bjørn Hansen <a...@develooper.com> wrote:
>
> On Mar 10, 2009, at 23:23, Hanno Hecker wrote:
>
> > diff --git a/lib/Qpsmtpd/SMTP.pm b/lib/Qpsmtpd/SMTP.pm
> > index f669055..bf21771 100644
> > --- a/lib/Qpsmtpd/SMTP.pm
> > +++ b/lib/Qpsmtpd/SMTP.pm
> > @@ -162,7 +162,8 @@ sub helo_respond {
> > my ($self, $rc, $msg, $args) = @_;
> > my ($hello_host) = @$args;
> > if ($rc == DONE) {
> > - # do nothing
> > + # do nothing:
> > + 1;
>
> If the intention here is to return 1 it should be an explicit "return
> 1" or just move the "return 1 as default" to the end of the method.
> (Otherwise it'll be easy for something else accidentally ending up as
> the last statement).
Right, it was the intention to return 1. Maybe do both. Most other subs
explicitly return directly after checking the $rc value.
Hanno
