Also note this won't work with -async properly. I'll have a look how it can be made to work asynchronously (you need to follow the respond style in the rest of the code).
On Mon, 09 Feb 2009 23:43:05 -0800, Robert Spier wrote: > > Committed as > > http://github.com/rspier/qpsmtpd/commit/a0ae0453264fe8dd85c132f2e7305b5ac34bf7e8 > > Did you actually test that this worked? I had to tweak the code to > make it make sense. Also, you had a mix of tabs and spaces and didn't > follow the style of the rest of the code. I cleaned them up this > time. > > -R > > Karl Y. Pradene wrote: >> >> On Mon, 09 Feb 2009 10:10:47 -0800 Robert Spier <rsp...@pobox.com> >> wrote: >> >>> >>>> Functionally, just about anything you can do here you can do just as >>>> >>>> I don't see a problem with adding it per-se. It'd make my >>>> plugins/config file ordering a trifle simpler, but it doesn't >>>> really add any functionality. I agree there should be a big >>>> warning about rejects/disconnects potentially being very dangerous. >>> >>> Chris' analysis [mostly snipped] is compelling. >>> >>> Karl, >>> Can you update the patch with >>> - documentation >>> - ... including a warning >>> - changing the name? >>> >>> And then I'll happily apply it. >>> >>> As Ask said, don't worry about bad english, that's easy enough to >>> fix later. >>> >>> >>> -R >> >> And voila. Hook renamed to data_headers_end, documentation in >> README.plugins with a BIG warning. >> >> $self->transaction->header($header) was moved earlier to have headers >> in transaction object when we call the hook. >> >> Regards. >> >> -- >> Karl Y. Pradene >
