On Thu, 22 May 2008, Chris Babcock wrote:
Chris Lewis wrote:
...
Killing transaction/connection notes() is a bit of a kludge, because
there's lots of other plugins who may be relying on the data being
persistent.
Without killing connection notes, I don't see any sane way to determine what
notes were generated before vs after TLS was enabled.
My point is that notes relating to the transaction should be in
connection->transaction, and those relating to the connection shouldn't
be. On TLS negotiation, the transaction notes must be cleared, and the
connection notes shouldn't be.
Unfortunately, for some
plugins that determination may be critical to the behavior of the plugin. It
seems to me retaining both the pre-TLS and post-TLS states would be the
closest to ideal, but I'm sure there's a way to do that sanely without
breaking how the current plugins are working.
If any plugins are currently doing the wrong thing, they should be
identified and fixed. Do we know that there are any currently "broken"
plugins?
