Hi everyone,

Most plugins seem to use the "whitelisthost" connection note, but a couple in the distribution are using "whitelistclient". Any objection to fixing those to be "whitelistclient" ? (whitelisthost makes more sense to me, but most plugins uses the other one - specifically the dns_whitelist_soft plugin does).

?

 - ask

Index: require_resolvable_fromhost
===================================================================
--- require_resolvable_fromhost (revision 890)
+++ require_resolvable_fromhost (working copy)
@@ -11,7 +11,7 @@
   my ($self, $transaction, $sender, %param) = @_;

   return DECLINED
-        if ($self->qp->connection->notes('whitelistclient'));
+        if ($self->qp->connection->notes('whitelisthost'));

   foreach my $i ($self->qp->config("invalid_resolvable_fromhost")) {
     $i =~ s/^\s*//;
Index: check_earlytalker
===================================================================
--- check_earlytalker   (revision 890)
+++ check_earlytalker   (working copy)
@@ -104,7 +104,7 @@
     my ($self, $transaction) = @_;

     return DECLINED unless $self->{_args}{'check-at'}{CONNECT};
- return DECLINED if ($self->qp->connection- >notes('whitelistclient'));
+    return DECLINED if ($self->qp->connection->notes('whitelisthost'));
     my $ip = $self->qp->connection->remote_ip;

     my $c = $self->qp->{conn};
@@ -132,7 +132,7 @@
     my ($self, $transaction) = @_;

     return DECLINED unless $self->{_args}{'check-at'}{DATA};
- return DECLINED if ($self->qp->connection- >notes('whitelistclient'));
+    return DECLINED if ($self->qp->connection->notes('whitelisthost'));
     my $ip = $self->qp->connection->remote_ip;

     my $c = $self->qp->{conn};
@@ -158,7 +158,7 @@

   return DECLINED unless $self->{_args}{'check-at'}{CONNECT};
   return DECLINED
-      if ($self->qp->connection->notes('whitelistclient'));
+      if ($self->qp->connection->notes('whitelisthost'));

   $in->add(\*STDIN) || return DECLINED;
   if ($in->can_read($self->{_args}->{'wait'})) {
@@ -183,7 +183,7 @@

   return DECLINED unless $self->{_args}{'check-at'}{DATA};
   return DECLINED
-      if ($self->qp->connection->notes('whitelistclient'));
+      if ($self->qp->connection->notes('whitelisthost'));

   $in->add(\*STDIN) || return DECLINED;
   if ($in->can_read($self->{_args}->{'wait'})) {


--
http://develooper.com/ - http://askask.com/


Reply via email to