Unknown Sender wrote:
* missing "use Qpsmtpd::Constants" here and there.
Committed.
* plugins/count_unrecognized_commands only resets it's internal
counter on init (this can't work well in preforking,
I've seen a couple of other plugins broken for prefork, like
the "delete $ENV{RELAYCLIENT};" in plugins/check_norelay)
I'm sending patches only for count_unrecognized_commands
Not committed. Needs more discussion. We should be resetting the
connection correctly, rather than forcing all plugins to cope with
different modalities.
* qpsmtpd-prefork: fix for taint mode execution (I donÂ't remember
if this module is with the -t switch or not, but I'm running
with it)
Committed.
Setting $0 = 'qpsmtpd child'; is not a good idea, it doesnt work as
intended in all *NIX flavours (maybe this is not a patch for all,
but it's commented out in all of the other files)
Turned into a flag, but I'm not sure that there is any point, since
Qpsmtpd::TcpServer *always* stomps on $0 already (see line 30). This
part may need to be reverted after discussion...
Thanks
John