On Fri, 8 Jul 2005, Matt Sergeant wrote:
On 8 Jul 2005, at 11:42, Charlie Brady wrote:
Nice approach indeed. Looks good, but I can see at least one problem (not
insurmountable) - STARTTLS should be removed from capabilities after TLS
is negotiated.
Isn't that done by reset_transaction?
You tell me. You surely know the code better than I do. :-)
[Checks] Yes, it does.
There's a potential structural problem here. Because we create a new
connection and a new transaction when we switch to TLS, we don't have
any way to remember anything from the SMTP conversation before the
transition to TLS. That's by design, and won't provide any problem with
communication with clients. But it's possible you might want to have that
information to assist in classifying ham/spam. Unlikely, IMO, but
possible.
Just bringing that to your attention. I think it's a limitation we can
live with, and fix if it ever becomes important. Could a connection have
notes, as well as/instead of a transaction?
