On Sat, 18 Jun 2005, Justin Erenkrantz wrote:
> --On June 18, 2005 11:08:40 AM -0500 Peter Eisch <[EMAIL PROTECTED]> wrote:
>
> > It should really just be:
> >
> > while (!$bb->is_empty) {
> > my $b = $bb->first;
> > $b->read(my $newdata);
> > $data .= $newdata;
> > return $data if index($data, "\n") >= 0;
> > }
>
> You need to declare $data first; but yah, I found the same issue and have
> almost an identical patch after we got complaints of broken emails. (I picked
> the *same* name for newdata. We rule!)
>
> We've stuck Apache::Qpsmtpd in some of our MXes to try it out. It's doing
> okay so far - but because of the corruption, I'm holding off switching more
> MXes over to it until I'm really sure we don't screw up email. -- justin
>
Yes, I have the 'my $data = "";' just like yours in the lines just above
the data collection while() loop.
Outside of the changes to Apache2 from Apache, this is what I've been
running without any problems for months.
I have one other modification in my version from a patch I submitted last
Dec which allows the logging to be done via a plugin. Instead of writing
to stderr (nay, warn()) I have all my logging going through a plugin
which syslogs to the mail facility with the qpsmtpd log level.
peter
