Some additional patches:
I'll review the actual patches in the next couple of days, but I wanted to give you some immediate feedback. I won't comment on every change but only the ones that make sense.
First off, you didn't actually mention which version of qpsmtpd these patches were created against, though of course the presence of RCS information suggests it is the CVS HEAD.
o lib/Qpsmtpd/SMTP.pm
- Assumes a MAIL FROM value of "<[EMAIL PROTECTED]>" (utilized by qmail to
Good catch.
- Adds LOGIN to the default list of supported auth mechanisms.
I did most of the implementation of the auth feature (based on some other's fine work, Hi Guillaume!) and other people have adjusted what I did (so that it actually worked properly, in some cases, thanks to Michael Holzt ;). The documentation never got updated to reflect that AUTH LOGIN works (though why you'd want to support yet another unincrypted login besides AUTH PLAIN is beyond me).
- Removes the "X-Qpsmtpd-Auth: True" header appended when a message
has been sent by an authenticated user.
Received: from remotehost (HELO remotehost) (192.168.42.42)
(smtp-auth username foo, mechanism cram-md5)
by mail.netisland.net (qpsmtpd/0.28) with ESMTP; <date>
This is a much nicer way of handling it!
- Fix to execute a generic auth hook when a more specific
auth-$mechanism hook does not exist. (Previously posted
to the list last week.)
Sorry, I saw that one and just haven't had time to deal with it...
o plugins/queue/qmail-queue
- Added a timestamp and the qmail-queue qp identifier to the
Another good catch
o plugins/check_badmailfrom:
- Changed the error message from "Mail from $bad not accepted here" to "sorry, your envelope sender is in my badmailfrom list", for compatibility with qmail-smtpd.
Probably a good idea.
As I said, I'll try and integrate these changes in the next couple of days, unless someone else beats me to it.
Thanks for the patches!
John
