"Michael Holzt" <[EMAIL PROTECTED]> : > The SMTP-Auth in the current version of QPSMTP ([CVS]) is broken and > wrong. I have fixed it and attached a diff. > > Problem 1: The AUTH PLAIN method > > This method is described in RFC2554 and RFC2595. The client forms a string > of the form "<NUL>username<NUL>password" and encodes this string using > base64. The command issued then is 'AUTH PLAIN <base64string>'.
You're right about that, for some unknown reason (I guess it's beer), I had assumed that AUTH PLAIN was plaintext username and password. I realized that this was wrong a few days ago, but I didn't had time to change it. Thanks for your patch. > Problem 2: The AUTH LOGIN method > > The supporting code for the LOGIN-Method is commented out in current CVS > implementation. [...] I have corrected the described problems and tested the code both manually by > issueing the apropiate commands as well as with real life clients like > TheBat. I'm certain, that the code now is correct for both AUTH LOGIN and > AUTH PLAIN, haven't checked the MD5 code yet. > > The diff is attached. Thanks for the fixes. Could someone with cvs commit privileges add this to CVS, please? Thanks, GFK's -- Guillaume Filion, ing. jr Logidac Tech., Beaumont, Qu�bec, Canada - http://logidac.com/ PGP Key and more: http://guillaume.filion.org/
