Hi Ismo, Thank you for proposing this Pull request and yes, this is the appropriate way to proceed.
Like I said in the PR, your work is overlapping another one I already proposed and which considerably modify the way topo points are managed in vertextool. I'll try to integrate your work in mine and test if everything works smoothly. Thanks for your contribution, Regards, Julien > Hello! > > Our customer reported a bug in the vertex tool when snapping on a segment > with the geometry precision enabled > (https://github.com/qgis/QGIS/issues/49311). After some studying, I thought I > found the cause and also a smooth fix for it. > > So now I have a bug fix and also a test function that fails without my fix. > Shall I make a pull request or what is the best way to proceed? I decided to > ask here > first because I have never made changes to the source code of QGIS earlier. I > have quite a long experience with C++ and Qt. I have read the developers guide > too. (And noticed that it is recommended to report here first when fixing the > bug but now I wasn’t sure at all if I can fix anything.) > > Best regards, > > Ismo Lahtinen > > Software developer > > Gispo Oy > > https://www.gispo.fi/en/ > > _______________________________________________ > QGIS-Developer mailing list > QGIS-Developer@lists.osgeo.org > List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer > Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer -- Julien Cabieces Senior Developer at Oslandia julien.cabie...@oslandia.com 09.72.52.52.76 _______________________________________________ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
