The QgsSettings::Section was an attempt to standardize. But applying it the whole code requires some more work.
Perhaps we should dedicate some bugfixing time to that (boring) task. What do you think about that? On Oct 28, 2017 00:48, "Nathan Woodrow" <[email protected]> wrote: > Hey Richard, > > Leave it with me I will take a look. I don't mind what we go with but we > should have a standard used over the whole app. > > Your PR is fine if /qgis/connections-wms s used in QGIS 3 and > Qgis/connections-wms was > in 2.x the translation framework will pick it up ok. > > Regards, > Nathan > > On Sat, Oct 28, 2017 at 1:13 AM, Richard Duivenvoorde <[email protected] > > wrote: > >> On 27-10-17 16:15, Nathan Woodrow wrote: >> > Sorry I'm not sure I follow what you mean? >> >> This pull fixed some WCS related changes, please see comments in the PR: >> >> https://github.com/qgis/QGIS/pull/4586 >> >> I also grepped (at that time) some other key's which contained Qgis with >> a capital Q (again see PR): >> >> python/pyplugin_installer/installer_data.py:reposGroup = >> "/Qgis/plugin-repos" >> python/pyplugin_installer/installer_data.py:settingsGroup = >> "/Qgis/plugin-installer" >> python/pyplugin_installer/installer_data.py:seenPluginGroup = >> "/Qgis/plugin-seen" >> python/pyplugin_installer/installer_data.py: ("Barry Rowlingson's >> Repository", >> "http://www.maths.lancs.ac.uk/~rowlings/Qgis/Plugins/plugins.xml";), >> python/pyplugin_installer/installer.py: lastDirectory = >> settings.value('/Qgis/plugin-installer/lastZipDirectory', '.') >> python/pyplugin_installer/installer.py: >> settings.setValue('/Qgis/plugin-installer/lastZipDirectory', >> python/qsci_apis/PyQGIS-2.0.api:qgis.gui.QgsNewHttpConnection?1(QWidget >> parent=None, QString baseKey="/Qgis/connections-wms/", QString >> connName=QString.null, Qt.WindowFlags fl=QgisGui.ModalDialogFlags) >> python/qsci_apis/PyQGIS-2.0.api:qgis.gui.QgsNewHttpConnectio >> n.__init__?1(self, >> QWidget parent=None, QString baseKey="/Qgis/connections-wms/", QString >> connName=QString.null, Qt.WindowFlags fl=QgisGui.ModalDialogFlags) >> python/qsci_apis/PyQGIS-2.2.api:qgis.gui.QgsNewHttpConnection?1(QWidget >> parent=None, QString baseKey="/Qgis/connections-wms/", QString >> connName=QString.null, Qt.WindowFlags fl=QgisGui.ModalDialogFlags) >> python/qsci_apis/PyQGIS-2.2.api:qgis.gui.QgsNewHttpConnectio >> n.__init__?1(self, >> QWidget parent=None, QString baseKey="/Qgis/connections-wms/", QString >> connName=QString.null, Qt.WindowFlags fl=QgisGui.ModalDialogFlags) >> python/gui/qgsnewhttpconnection.sip: QgsNewHttpConnection( QWidget >> *parent /TransferThis/ = 0, const QString &baseKey = >> "/Qgis/connections-wms/", const QString &connName = QString::null, const >> Qt::WindowFlags &fl = QgsGuiUtils::ModalDialogFlags ); >> python/plugins/MetaSearch/dialogs/maindialog.py: # stype = human >> name,/Qgis/connections-%s,providername >> python/plugins/MetaSearch/dialogs/maindialog.py: >> self.settings.beginGroup('/Qgis/connections-%s' % stype[2]) >> python/plugins/MetaSearch/dialogs/maindialog.py: >> self.settings.beginGroup('/Qgis/connections-%s' % stype[1]) >> python/plugins/MetaSearch/dialogs/maindialog.py: >> self.settings.beginGroup('/Qgis/connections-%s' % stype[2]) >> python/plugins/MetaSearch/dialogs/maindialog.py: >> self.settings.beginGroup('/Qgis/connections-%s' % stype[1]) >> >> But I understand now that yours is just about settings object/file, NOT >> so much about the code that creates that settings? >> >> Richard >> > > > _______________________________________________ > QGIS-Developer mailing list > [email protected] > List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer > Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer >
_______________________________________________ QGIS-Developer mailing list [email protected] List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
