On 12.07.2017 11:41, Luigi Pirelli wrote:
why not add the feature to a more detailed notification of what is
wrong during commitChanges? Like point out a more detailed report of
the failing feature/attribute/geometry? it would just a new signal and
EditBuffer cache.

Uhm but that would still mean the changeset cannot be committed.

And as a side-note, the edit-buffer inbetween brings a number of challenges like:
- The user manually exiting the edit mode while the plugin is working
- The user changing something outside the control of the plugin. The plugin is fairly complex in that it updates all other errors based on the outcome of a fix - say, if you delete a duplicate node, it may have an effect of the vertex id used to describe a "minimal angle" error. Updating the errors works well as long as the plugin knows exactly what is going on, but if the user starts fiddling inbetween, it gets a real proper nightmare to track and handle all changes. Indeed, currently the plugin sets the layers to non-editable while it is working so that, short of removing the layer from the project, there is not much the user can do to interfere with the logic of the plugin.

Sandro
_______________________________________________
QGIS-Developer mailing list
[email protected]
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Reply via email to