On Wed, Oct 18, 2023 at 04:27:31PM -0300, Fabiano Rosas wrote: > +/** > + * qtest_init_with_env: > + * @var: Environment variable from where to take the QEMU binary > + * @extra_args: Other arguments to pass to QEMU. CAUTION: these > + * arguments are subject to word splitting and shell evaluation. > + * > + * Like qtest_init(), but use a different environment variable for the > + * QEMU binary. > + * > + * Returns: #QTestState instance. > + */ > +QTestState *qtest_init_with_env(const char *var, const char *extra_args);
Another way to do is instead of passing over the env var, passing over "char *qemu_bin" always, and take qtest_qemu_binary() as default. Also relevant to patch 1. Not a big deal though, so can be done for later. Thanks, -- Peter Xu
