>> -device >>vfio-pci-nohotplug,host=0009:01:00.0,bus=pcie.0,addr=04.0,rombar=0,id=dev0 \ >> -object >>nvidia-acpi-generic-initiator,id=gi0,device=dev0,numa-node-start=2,numa-node-count=8 > > Why didn't we just implement start and count in the base object (or a > list)? It seems like this gives the nvidia-acpi-generic-initiator two > different ways to set gi->node, either node= of the parent or > numa-node-start= here. Once we expose the implicit node count in the > base object, I'm not sure the purpose of this object. I would have > thought it for keying the build of the NVIDIA specific _DSD, but that's > not implemented in this version.
Agree, allowing a list of nodes to be provided to the acpi-generic-initiator will remove the need for the nvidia-acpi-generic-initiator object. > I also don't see any programatic means for management tools to know how > many nodes to create. For example what happens if there's a MIGv2 that > supports 16 partitions by default and makes use of the same vfio-pci > variant driver? Thanks, It is supposed to stay at 8 for all the G+H devices. Maybe this can be managed through proper documentation in the user manual?