>> +static void acpi_generic_initiator_set_node(Object *obj, Visitor *v,
>> + const char *name, void *opaque,
>> + Error **errp)
>> +{
>> + AcpiGenericInitiator *gi = ACPI_GENERIC_INITIATOR(obj);
>> + uint32_t value;
>> +
>> + if (!visit_type_uint32(v, name, &value, errp)) {
>> + return;
>> + }
>> +
>> + if (value >= MAX_NODES) {
>
> error_setg() here? Thanks,
Thanks for pointing out, will make the change in the next version.
>> +##
>> +# @AcpiGenericInitiatorProperties:
>> +#
>> +# Properties for acpi-generic-initiator objects.
>> +#
>> +# @device: the ID of the device to be associated with the node
>> +#
>> +# @node: the ID of the numa node
>> +#
>> +# Since: 8.0
>
> Since 8.2
Thanks, will make the change.
>> 'tls-creds-x509',
>> 'tls-cipher-suites',
>> { 'name': 'x-remote-object', 'features': [ 'unstable' ] },
>> - { 'name': 'x-vfio-user-server', 'features': [ 'unstable' ] }
>> + { 'name': 'x-vfio-user-server', 'features': [ 'unstable' ] },
>> + 'acpi-generic-initiator'
>
> Please keep the object types sorted alphabetically.
Ack.
>> @@ -1014,7 +1029,8 @@
>> 'tls-creds-x509': 'TlsCredsX509Properties',
>> 'tls-cipher-suites': 'TlsCredsProperties',
>> 'x-remote-object': 'RemoteObjectProperties',
>> - 'x-vfio-user-server': 'VfioUserServerProperties'
>> + 'x-vfio-user-server': 'VfioUserServerProperties',
>> + 'acpi-generic-initiator': 'AcpiGenericInitiatorProperties'
>
> Likewise.
Ack, will make the change.
