On Fri, 13 Oct 2023 11:46:42 +0300
Emmanouil Pitsidianakis <manos.pitsidiana...@linaro.org> wrote:
> In preparation of raising -Wimplicit-fallthrough to 5, replace all
> fall-through comments with the fallthrough attribute pseudo-keyword.
>
> Signed-off-by: Emmanouil Pitsidianakis <manos.pitsidiana...@linaro.org>
Looking at this, I think the code in question needs a closer look, cleanup
but that has nothing to do with what you are doing here!
Acked-by: Jonathan Cameron <jonathan.came...@huawei.com>
> ---
> hw/cxl/cxl-device-utils.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/cxl/cxl-device-utils.c b/hw/cxl/cxl-device-utils.c
> index bd68328032..63f009847e 100644
> --- a/hw/cxl/cxl-device-utils.c
> +++ b/hw/cxl/cxl-device-utils.c
> @@ -80,7 +80,7 @@ static void mailbox_mem_writel(uint32_t *reg_state, hwaddr
> offset,
> {
> switch (offset) {
> case A_CXL_DEV_MAILBOX_CTRL:
> - /* fallthrough */
> + fallthrough;
> case A_CXL_DEV_MAILBOX_CAP:
> /* RO register */
> break;
> @@ -102,7 +102,7 @@ static void mailbox_mem_writeq(uint64_t *reg_state,
> hwaddr offset,
> break;
> case A_CXL_DEV_BG_CMD_STS:
> /* BG not supported */
> - /* fallthrough */
> + fallthrough;
> case A_CXL_DEV_MAILBOX_STS:
> /* Read only register, will get updated by the state machine */
> return;
