Re: [PATCH 05/12] lasips2: LASI PS/2 devices are not user-createable

[BALATON Zoltan]

On Sat, 14 Oct 2023, del...@kernel.org wrote:
From: Helge Deller <del...@gmx.de>
Those PS/2 ports are created with the LASI controller when
a 32-bit PA-RISC machine is created.

Mark them not user-createable to avoid showing them in
the qemu device list.

Signed-off-by: Helge Deller <del...@gmx.de>
Cc: qemu-sta...@nongnu.org
---
hw/input/lasips2.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/hw/input/lasips2.c b/hw/input/lasips2.c
index ea7c07a2ba..93c9c887d3 100644
--- a/hw/input/lasips2.c
+++ b/hw/input/lasips2.c
@@ -351,6 +351,8 @@ static void lasips2_port_class_init(ObjectClass *klass, 
void *data)
{
    DeviceClass *dc = DEVICE_CLASS(klass);

+    /* Lasi devices can not be created by users */

That's what the next line says so this comment does not add any info. It 
should instead explain why, such as "part of LASI" or something like that.

Regards,
BALATON Zoltan

+    dc->user_creatable = false;
    dc->realize = lasips2_port_realize;
}

@@ -397,6 +399,8 @@ static void lasips2_kbd_port_class_init(ObjectClass *klass, 
void *data)
    DeviceClass *dc = DEVICE_CLASS(klass);
    LASIPS2PortDeviceClass *lpdc = LASIPS2_PORT_CLASS(klass);

+    /* Lasi devices can not be created by users */
+    dc->user_creatable = false;
    device_class_set_parent_realize(dc, lasips2_kbd_port_realize,
                                    &lpdc->parent_realize);
}