On 10/13/23 01:45, Emmanouil Pitsidianakis wrote:
--
Resending because --function-context was accidentally used in the
previous version. Sincere apologies for the noise.
--
Hello,
This RFC is inspired by the kernel's move to -Wimplicit-fallthrough=3
back in 2019.[0]
We take one step (or two) further by increasing it to 5 which rejects
fall through comments and requires an attribute statement.
[0]:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a035d552a93b
The line differences are not many, but they spread all over different
subsystems, architectures and devices. An attempt has been made to split
them in cohesive patches to aid post-RFC review. Part of the RFC is to
determine whether these patch divisions needs improvement.
Main questions this RFC poses
=============================
- Is this change desirable and net-positive.
Did this catch any new problems? If not, I really don't see the benefit.
The compiler comment matching appears to be sufficient.
r~
