On Friday, August 4, 2023 9:37 PM, Peter Xu wrote: Fri, Aug 04, 2023 at 05:30:53PM +0800, Wei Wang wrote: > > Current migration_completion function is a bit long. Refactor the long > > implementation into different subfunctions: > > - migration_completion_precopy: completion code related to precopy > > - migration_completion_postcopy: completion code related to postcopy > > - close_return_path_on_source: rp thread related cleanup on migration > > completion. It is named to match with open_return_path_on_source. > > > > This improves readability and is easier for future updates (e.g. add > > new subfunctions when completion code related to new features are > > needed). No functional changes intended. > > > > Signed-off-by: Wei Wang <wei.w.w...@intel.com> > > Reviewed-by: Peter Xu <pet...@redhat.com> >
Hi Juan, Do you think this refactoring would be good to merge or have any more comments? Thanks, Wei
