On Wed Oct 11, 2023 at 7:55 AM AEST, Warner Losh wrote: > On Tue, Oct 10, 2023 at 1:53 AM Nicholas Piggin <npig...@gmail.com> wrote: > > > FreeBSD project provides qcow2 images that work well for testing QEMU. > > Add pseries tests for HPT and Radix, KVM and TCG. > > > > Other architectures could be added so this does not get a ppc_ prefix > > but is instead named similarly to boot_linux. > > > > Cc: Warner Losh <i...@bsdimp.com> > > Signed-off-by: Nicholas Piggin <npig...@gmail.com> > > > > CC'ing Warner to check if it's okay for us to use these images and > > any comments or suggestions. avocado tests have many Linux boots so we'd > > do much better to expand test coverage by adding some other systems. > > > > I like this.... I'm a little worried at the exact hash encoded in it, but > since there's a checksum > to match, it's OK I guess. It will give this code a shelf-life of months, > IIRC our retention policy.
Oh I didn't realise, I saw some 2021 dates in the directory listing but looks like they're not for the artifacts themselves. I don't suppose you know if there are any long-term artifacts kept around, or someone who I could ask? The downside of using short term images is that it can be harder to reproduce reports from others, bisect, run manual testing, etc. I think these would still be useful, so long as they get updated regularly. > > Other than that, I think this is good. Not familiar enough with Avocado to > understand > skipping for gitlab CI, but given the extreme crunch on minutes, I think > that's OK. Yeah I'm not sure what the situation there is, I didn't want to add new tests of any significant weight yet. We could always flip it on later if people want it. > > Other than one nit below which is fine if it is intentionally left behind > (or removed): > > Reviewed-by: Warner Losh <i...@bsdimp.com> > > Please don't hesitate to reach out to me if this is failing. I'll act as a > backstop to get > it to the right people. Thanks Warner. > > Warner > > [snip] > > + def run_pseries_test(self, force_HPT=False): > > + # We need zstd for all the tuxrun tests > > + # See https://github.com/avocado-framework/avocado/issues/5609 > > + zstd = find_command('zstd', False) > > + if zstd is False: > > + self.cancel('Could not find "zstd", which is required to ' > > + 'decompress rootfs') > > + self.zstd = zstd > > + > > + drive_url = (' > > https://artifact.ci.freebsd.org/snapshot/15.0-CURRENT/a2440348eed75bb7682579af0905b652747fd016/powerpc/powerpc64le/disk.qcow2.zst > > ') > > + drive_hash = '8ab11a05ccab3d44215fd4667a70454ed10a203f' > > + drive_path_zstd = self.fetch_asset(drive_url, > > asset_hash=drive_hash) > > + drive_path = os.path.join(self.workdir, 'disk.qcow2') > > + # archive.zstd_uncompress(drive_path_zstd, drive_path) > > > > Why is this commented out? It looks like a leftover maybe? > Ah yes, avocado recently got zstd_uncompress but it seems not available for QEMU yet so we have to do it by hand. I'll remove. Thanks, Nick
