On 02/29/2012 06:39 PM, Michael S. Tsirkin wrote: > On Wed, Feb 29, 2012 at 06:36:10PM +0200, Avi Kivity wrote: > > On 02/29/2012 06:18 PM, Anthony Liguori wrote: > > > On 02/29/2012 10:16 AM, Michael S. Tsirkin wrote: > > >> Valgrind shows a memory leak below: > > > > > > Is this with Avi's latest branch or is this in qemu.git? > > > > Looks like qemu.git. > > This is a merge of your for-mst and my bridge patches. > Take a look at 'valgrind' branch on my github tree > if you like: >
The bug is present in qemu.git, my patches don't touch it: void isa_register_portio_list(ISADevice *dev, uint16_t start, const MemoryRegionPortio *pio_start, void *opaque, const char *name) { PortioList *piolist = g_new(PortioList, 1); ^ leaked /* START is how we should treat DEV, regardless of the actual contents of the portio array. This is how the old code actually handled e.g. the FDC device. */ isa_init_ioport(dev, start); portio_list_init(piolist, pio_start, opaque, name); portio_list_add(piolist, isabus->address_space_io, start); } It's only a problem if we allow unplug, which we shouldn't for these devices. -- error compiling committee.c: too many arguments to function