On 2023-09-28, Richard Henderson <richard.hender...@linaro.org> wrote: > Belated follow-up suggestion: > > - if ((tmp & 0xff) > 0x7f) { > - tmp += 0x100; > - } > + tmp += 0x80; > > 7 occurrences throughout vis_helper.c.
I agree with making this particular change but I think since it doesn't fix a bug, it should go in a separate patch. So I will include a patch to do that in series v2 and keep this one as-is with your Reviewed-by. Thanks, Nick