Re: [PATCH v3 7/7] Update the ACPI table for the Loongarch CPU

[lixianglai]

Hi Salil Mehta:

Hi Xianglai,

From: xianglai li <lixiang...@loongson.cn>
Sent: Tuesday, September 26, 2023 10:55 AM
To: qemu-devel@nongnu.org
Cc: Bernhard Beschow <shen...@gmail.com>; Salil Mehta
<salil.me...@opnsrc.net>; Salil Mehta <salil.me...@huawei.com>; Xiaojuan
Yang <yangxiaoj...@loongson.cn>; Song Gao <gaos...@loongson.cn>; Michael S.
Tsirkin <m...@redhat.com>; Igor Mammedov <imamm...@redhat.com>; Ani Sinha
<anisi...@redhat.com>; Paolo Bonzini <pbonz...@redhat.com>; Richard
Henderson <richard.hender...@linaro.org>; Eduardo Habkost
<edua...@habkost.net>; Marcel Apfelbaum <marcel.apfelb...@gmail.com>;
Philippe Mathieu-Daudé <phi...@linaro.org>; wangyanan (Y)
<wangyana...@huawei.com>; Daniel P. Berrangé <berra...@redhat.com>; Peter
Xu <pet...@redhat.com>; David Hildenbrand <da...@redhat.com>; Bibo Mao
<maob...@loongson.cn>
Subject: [PATCH v3 7/7] Update the ACPI table for the Loongarch CPU

Add new types of GED devices for Loongarch machines,
add CPU hot-(un)plug event response and address spaces,
and update the ACPI table.

Cc: "Bernhard Beschow" <shen...@gmail.com>
Cc: "Salil Mehta" <salil.me...@opnsrc.net>
Cc: "Salil Mehta" <salil.me...@huawei.com>
Cc: Xiaojuan Yang <yangxiaoj...@loongson.cn>
Cc: Song Gao <gaos...@loongson.cn>
Cc: "Michael S. Tsirkin" <m...@redhat.com>
Cc: Igor Mammedov <imamm...@redhat.com>
Cc: Ani Sinha <anisi...@redhat.com>
Cc: Paolo Bonzini <pbonz...@redhat.com>
Cc: Richard Henderson <richard.hender...@linaro.org>
Cc: Eduardo Habkost <edua...@habkost.net>
Cc: Marcel Apfelbaum <marcel.apfelb...@gmail.com>
Cc: "Philippe Mathieu-Daudé" <phi...@linaro.org>
Cc: Yanan Wang <wangyana...@huawei.com>
Cc: "Daniel P. Berrangé" <berra...@redhat.com>
Cc: Peter Xu <pet...@redhat.com>
Cc: David Hildenbrand <da...@redhat.com>
Cc: Bibo Mao <maob...@loongson.cn>
Signed-off-by: xianglai li <lixiang...@loongson.cn>
---
  hw/acpi/acpi-cpu-hotplug-stub.c |  9 +++++++++
  hw/loongarch/acpi-build.c       | 34 ++++++++++++++++++++++++++++++++-
  hw/loongarch/virt.c             |  3 ++-
  include/hw/loongarch/virt.h     |  1 +
  4 files changed, 45 insertions(+), 2 deletions(-)

diff --git a/hw/acpi/acpi-cpu-hotplug-stub.c b/hw/acpi/acpi-cpu-hotplug-
stub.c
index 2aec90d968..b3ac7a1e31 100644
--- a/hw/acpi/acpi-cpu-hotplug-stub.c
+++ b/hw/acpi/acpi-cpu-hotplug-stub.c
@@ -19,6 +19,15 @@ void legacy_acpi_cpu_hotplug_init(MemoryRegion *parent,
Object *owner,
      return;
  }

+void build_cpus_aml(Aml *table, MachineState *machine, CPUHotplugFeatures
opts,
+                    build_madt_cpu_fn build_madt_cpu, hwaddr mmap_io_base,
+                    const char *res_root,
+                    const char *event_handler_method,
+                    AmlRegionSpace rs)
+{
+    return;
+}
+
  void acpi_cpu_ospm_status(CPUHotplugState *cpu_st, ACPIOSTInfoList
***list)
  {
      return;

Ok, I'll take care of that.

Thanks,

Xianglai.

Above change is already part of the architecture agnostic patch-set.
Not required here!

Thanks
Salil.