On Tue, Sep 26, 2023 at 11:15:30PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> NVMeQueuePair::reqs has length NVME_NUM_REQS, which less than
> NVME_QUEUE_SIZE by 1.
> 
> Fixes: 1086e95da17050 ("block/nvme: switch to a NVMeRequest freelist")
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@yandex-team.ru>
> ---
> 
> Cc: stefa...@redhat.com
> Cc: alex.c...@huawei.com
> Cc: euler.ro...@huawei.com
> 
> Note, that there was similar patch in the past:
>  https://patchew.org/QEMU/20201208144452.91172-1-alex.c...@huawei.com/
> I still think, that using NVME_NUM_REQS is better here.
> 
>  block/nvme.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>

Attachment: signature.asc
Description: PGP signature

Reply via email to