Perter,
On 20/09/2023 00:49, Peter Xu wrote: > On Mon, Sep 18, 2023 at 04:41:14PM +0200, Markus Armbruster wrote: >> Oh dear, where to start. There's so much wrong, and in pretty obvious >> ways. This code should never have passed review. I'm refraining from >> saying more; see the commit messages instead. >> >> Issues remaining after this series include: >> >> * Terrible error messages >> >> * Some error message cascades remain >> >> * There is no written contract for QEMUFileHooks, and the >> responsibility for reporting errors is unclear > > Even being removed.. because no one is really extending that.. > > https://lore.kernel.org/all/20230509120700.78359-1-quint...@redhat.com/#t > >> >> * There seem to be no tests whatsoever > > I always see rdma as "odd fixes" stage.. for a long time. But maybe I was > wrong. > > Copying Zhijian for status of rdma; Thanks, Yeah, sometimes I will pay attention to migration, especially patches related to RDMA and COLO. I just knew i have missed so much patches to RDMA, most of them had got RVB, but dropped at PULL phase at last. What a pity. Zhijian, I saw that you just replied to > the hwpoison issue. Maybe we should have one entry for rdma too, just like > colo? I'm worried that I may not have enough time, ability, or environment to review/test the RDMA patches. but for this patch set, i will take a look later. Thanks Zhijian > > Thanks, >
