>-----Original Message----- >From: Eric Auger <eric.au...@redhat.com> >Sent: Wednesday, September 20, 2023 9:54 PM >Subject: Re: [PATCH v1 13/22] vfio: Add base container > >Hi Cedric, > >On 9/19/23 19:23, Cédric Le Goater wrote: >> On 8/30/23 12:37, Zhenzhong Duan wrote: >>> From: Yi Liu <yi.l....@intel.com> >>> >>> Abstract the VFIOContainer to be a base object. It is supposed to be >>> embedded by legacy VFIO container and later on, into the new iommufd >>> based container. >>> >>> The base container implements generic code such as code related to >>> memory_listener and address space management. The VFIOContainerOps >>> implements callbacks that depend on the kernel user space being used. >>> >>> 'common.c' and vfio device code only manipulates the base container with >>> wrapper functions that calls the functions defined in >>> VFIOContainerOpsClass. >>> Existing 'container.c' code is converted to implement the legacy >>> container >>> ops functions. >>> >>> Below is the base container. It's named as VFIOContainer, old >>> VFIOContainer >>> is replaced with VFIOLegacyContainer. >> >> Usualy, we introduce the new interface solely, port the current models >> on top of the new interface, wire the new models in the current >> implementation and remove the old implementation. Then, we can start >> adding extensions to support other implementations. >> spapr should be taken care of separatly following the principle above. >> With my PPC hat, I would not even read such a massive change, too risky >> for the subsystem. This path will need (much) further splitting to be >> understandable and acceptable. >> >> Also, please include the .h file first, it helps in reading. Have you >> considered using an InterfaceClass ? >in the transition from v1 -> v2, I removed the QOMification of the >VFIOContainer, following David Gibson's advice. QOM objects are visible >from the user interface and there was no interest in that. Does it >answer your question? > >- remove the QOMification of the VFIOContainer and simply use standard ops >(David) > >Unfortunately the coverletter log history has disappeared in this new version. >Zhenzhong, I think it is useful to understand how the series moves on.
I have archive it with a link https://lists.nongnu.org/archive/html/qemu-devel/2023-07/msg02529.html for cleaner cover letter, looks I'm wrong. I'll restore the whole changelog in v2. Thanks Zhenzhong
