On Sun, Sep 17, 2023 at 10:39 PM Karim Taha <kariem.taha...@gmail.com>
wrote:
> From: Stacey Son <s...@freebsd.org>
>
> Signed-off-by: Stacey Son <s...@freebsd.org>
> Signed-off-by: Karim Taha <kariem.taha...@gmail.com>
> Reviewed-by: Richard Henderson <richard.hender...@linaro.org>
> ---
> bsd-user/freebsd/os-proc.h | 23 +++++++++++++++++++++++
> bsd-user/freebsd/os-syscall.c | 8 ++++++++
> 2 files changed, 31 insertions(+)
>
> diff --git a/bsd-user/freebsd/os-proc.h b/bsd-user/freebsd/os-proc.h
> index 1866f0b2d6..47bcdcf8a3 100644
> --- a/bsd-user/freebsd/os-proc.h
> +++ b/bsd-user/freebsd/os-proc.h
> @@ -34,6 +34,8 @@ pid_t safe_wait4(pid_t wpid, int *status, int options,
> struct rusage *rusage);
> pid_t safe_wait6(idtype_t idtype, id_t id, int *status, int options,
> struct __wrusage *wrusage, siginfo_t *infop);
>
> +extern int __setugid(int flag);
> +
> /* execve(2) */
> static inline abi_long do_freebsd_execve(abi_ulong path_or_fd, abi_ulong
> argp,
> abi_ulong envp)
> @@ -155,4 +157,25 @@ static inline abi_long
> do_freebsd_getloginclass(abi_ulong arg1, abi_ulong arg2)
> return ret;
> }
>
> +/* pdgetpid(2) */
> +static inline abi_long do_freebsd_pdgetpid(abi_long fd, abi_ulong
> target_pidp)
> +{
> + abi_long ret;
> + pid_t pid;
> +
> + ret = get_errno(pdgetpid(fd, &pid));
> + if (!is_error(ret)) {
> + if (put_user_u32(pid, target_pidp)) {
> + return -TARGET_EFAULT;
> + }
> + }
> + return ret;
> +}
> +
> +/* undocumented __setugid */
> +static inline abi_long do_freebsd___setugid(abi_long arg1)
> +{
> + return get_errno(__setugid(arg1));
>
This should be return -TARGET_ENOSYS since the kernel doesn't implement
it for anything except a regression test.... And what it does is quite
dangerous,
so we don't want someone to think it's a good idea to implement it in the
future.
Warner
> +}
> +
> #endif /* BSD_USER_FREEBSD_OS_PROC_H */
> diff --git a/bsd-user/freebsd/os-syscall.c b/bsd-user/freebsd/os-syscall.c
> index d614409e69..99af0f6b15 100644
> --- a/bsd-user/freebsd/os-syscall.c
> +++ b/bsd-user/freebsd/os-syscall.c
> @@ -383,6 +383,14 @@ static abi_long freebsd_syscall(void *cpu_env, int
> num, abi_long arg1,
> ret = do_freebsd_getloginclass(arg1, arg2);
> break;
>
> + case TARGET_FREEBSD_NR_pdgetpid: /* pdgetpid(2) */
> + ret = do_freebsd_pdgetpid(arg1, arg2);
> + break;
> +
> + case TARGET_FREEBSD_NR___setugid: /* undocumented */
> + ret = do_freebsd___setugid(arg1);
> + break;
> +
> case TARGET_FREEBSD_NR_utrace: /* utrace(2) */
> ret = do_bsd_utrace(arg1, arg2);
> break;
> --
> 2.42.0
>
>
