Re: [PATCH v2 09/18] vhost-user-gpu: skip VHOST_USER_GPU_UPDATE when !PIXMAN

[Paolo Bonzini]

On 9/18/23 15:51, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau <marcandre.lur...@redhat.com>
This simply means that 2d drawing updates won't be handled, but 3d
should work.

Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com>

How bad is this?  Is it worth making the device dependent on pixman 
altogether?

Paolo

---
  hw/display/vhost-user-gpu.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/hw/display/vhost-user-gpu.c b/hw/display/vhost-user-gpu.c
index 1150521d9d..709c8a02a1 100644
--- a/hw/display/vhost-user-gpu.c
+++ b/hw/display/vhost-user-gpu.c
@@ -307,6 +307,7 @@ vhost_user_gpu_handle_display(VhostUserGPU *g, 
VhostUserGpuMsg *msg)
          dpy_gl_update(con, m->x, m->y, m->width, m->height);
          break;
      }
+#ifdef CONFIG_PIXMAN
      case VHOST_USER_GPU_UPDATE: {
          VhostUserGpuUpdate *m = &msg->payload.update;
  
@@ -334,6 +335,7 @@ vhost_user_gpu_handle_display(VhostUserGPU *g, VhostUserGpuMsg *msg)
          }
          break;
      }
+#endif
      default:
          g_warning("unhandled message %d %d", msg->request, msg->size);
      }